Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macros: use zero_reference_position when using beacon true zero #315

Open
wants to merge 3 commits into
base: v2.1.x
Choose a base branch
from

Conversation

miklschmidt
Copy link
Member

This prevents scanned meshes from being offset from the true zero position, which results in an unintended additional z_offset to be applied via the incorrect bed mesh.

@miklschmidt miklschmidt requested a review from HelgeKeck November 9, 2024 20:35
@miklschmidt
Copy link
Member Author

miklschmidt commented Nov 9, 2024

Great, there's no way to set zero_reference_position dynamically...

@miklschmidt
Copy link
Member Author

miklschmidt commented Nov 10, 2024

This now does 2 things:

  1. Adds a sanity check, to ensure zero_reference_position is set to safe_z_home coordinates.
  2. Allows the user to enable model calibration each print. We might need to make this default, it seems there are issues when doing the contact wipe without at least zeroing via contact before probing, when switching between significantly different bed surfaces.

@miklschmidt
Copy link
Member Author

miklschmidt commented Nov 10, 2024

Update to point 2: It now zeroes Z before doing the contact wipe, regardless if a new model would be calibrated or not. This is to avoid the issue with vastly different bed plate material thickness, the probed offset does not seem to work in that case - not sure why.

@HelgeKeck
Copy link
Collaborator

looks good to me

@evilC
Copy link

evilC commented Dec 6, 2024

Is this and 31 likely to get merged?
I am still on the workaround code, so it's performing a full scan of the bed rather than just the used area.
Normally this is not an issue, but I have a print where I am going to need to use foldback clips to stop the build plate from being pulled away from the heated bed, so would like to go back to the smaller scan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants